Simplify typings #1520
Merged
Simplify typings #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
The TypeScript typings are pretty complicated to describe default export of a Command object in addition to
Classes. This was appropriate at the time as a faithful description of the javascript implementation.
Related issues: #1037 #1465 and mention in #1392 (comment)
#1037 was previously fixed by describing the class constructors as separate functions. (Yuck.)
Solution
Remove the default export of the program object and use named exports. Way simpler and tidier!
The default import of global Command object was removed from README in Commander v5. Deprecated from Commander v7. Deleted in this PR.
Fixes #1465 (and #1037 fixed too, in new way)
(Hide whitespace changes to make the diff look much simpler.)
ChangeLog