Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for conflicts in parent commands #1711

Merged
merged 5 commits into from
Mar 25, 2022
Merged

Check for conflicts in parent commands #1711

merged 5 commits into from
Mar 25, 2022

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

Only testing for conflicts in leaf command.

See: #1710

Solution

Follow same pattern as checking for required options:

  • run up parents checking them as well
  • call in dispatch to external command too

ChangeLog

Fixes:

abetomo
abetomo reviewed Mar 25, 2022
View reviewed changes
lib/command.js Outdated Show resolved Hide resolved
abetomo
abetomo approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadowspawn shadowspawn merged commit bf205d1 into tj:develop Mar 25, 2022
@shadowspawn shadowspawn deleted the feature/fix-conflicts-1710 branch March 25, 2022 20:53
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Mar 25, 2022
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadowspawn @abetomo