Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken typescript-checkJS script. Store config for the script in jsconfig.json so that it is picked up by VS Code #1962

Closed
wants to merge 3 commits into from

Conversation

aweebit
Copy link
Contributor

@aweebit aweebit commented Aug 13, 2023

This is an extension of #1960 renaming files in such a way that the right TSConfig is picked up by VS Code for live checks that lead to error highlighting.

  • tsconfig.checkJs.json -> jsconfig.json
  • tsconfig.json -> tsconfig.base.json
    • cannot coexist with jsconfig.json under the old name since it would be picked up by VS Code instead
    • the file is still used in .eslint.rc, but maybe that is not necessary and the new tsconfig.json could be used instead

For better consistency with the TSConfig option name.

The script had been broken for a long time, so it is safe to assume
nobody relies on the old name in custom scripts.
@aweebit
Copy link
Contributor Author

aweebit commented Aug 15, 2023

Closing in favor of #1969.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants