Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore extra sanity check when enabling storeOptionsAsProperties #2029

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Restore extra sanity check when enabling storeOptionsAsProperties #2029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/command.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,9 +761,9 @@ Expecting one of '${allowedValues.join("', '")}'`);
if (this.options.length) {
throw new Error('call .storeOptionsAsProperties() before adding options');
}
// if (Object.keys(this._optionValues).length) {
// throw new Error('call .storeOptionsAsProperties() before setting option values');
// }
if (Object.keys(this._optionValues).length) {
throw new Error('call .storeOptionsAsProperties() before setting option values');
}
this._storeOptionsAsProperties = !!storeAsProperties;
return this;
}
Expand Down
14 changes: 7 additions & 7 deletions tests/commander.configureCommand.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ test('when storeOptionsAsProperties() after adding option then throw', () => {
}).toThrow();
});

// test('when storeOptionsAsProperties() after setting option value then throw', () => {
// const program = new commander.Command();
// program.setOptionValue('foo', 'bar');
// expect(() => {
// program.storeOptionsAsProperties();
// }).toThrow();
// });
test('when storeOptionsAsProperties() after setting option value then throw', () => {
const program = new commander.Command();
program.setOptionValue('foo', 'bar');
expect(() => {
program.storeOptionsAsProperties();
}).toThrow();
});