Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Modernize codebase to ES6 #661

Closed
wants to merge 7 commits into from
Closed

[WIP] Modernize codebase to ES6 #661

wants to merge 7 commits into from

Conversation

roman-vanesyan
Copy link
Collaborator

No description provided.

@roman-vanesyan
Copy link
Collaborator Author

@abetomo @zhiyelee Hey, I considering updating testing infra and I'd like to decide on testing framework as well, should we update sinon to the most current version, or should we switch to something like jest, ava, etc.?

@abetomo
Copy link
Collaborator

abetomo commented Jul 19, 2017

I would like to cast a vote on the plan to switch to jest.

@abetomo
Copy link
Collaborator

abetomo commented Sep 21, 2017

@vanesyan Could you tell us about your future development schedule?

@roman-vanesyan
Copy link
Collaborator Author

Currently the branch contains only convertion of the codebase to es6 and separation of classes per file, everything working pretty well on Node.js 8+. The first thing we should recognize which minimal version of Node.js we support.

@roman-vanesyan
Copy link
Collaborator Author

Also, the plan was to incrementally improve the codebase. Currently commander consists of set of hacks to support different cases IMHO, we should minimize such a things and canonize most of parts of commander.

@roman-vanesyan
Copy link
Collaborator Author

Another one part of the plan was to implement critical futures people request for a long time, for instance long awaited future like control the flow of processing of required options, arguments.

@roman-vanesyan
Copy link
Collaborator Author

Probably, we shouldn't merge this pr into master, rather we should create dev branch and merge all commits the we want to be landed into v3 there.

@abetomo
Copy link
Collaborator

abetomo commented Sep 22, 2017

@vanesyan Thank you for your reply.

I also have some suggestions for improvement.
Probably most of it will be improved with this fix.
I think that this code will eventually remain, so it is highly likely that you will be wasted even if you modify the existing code.

So I would like to do this with this new branch if I am going to fix it.
Could you please let me make it possible for multiple people to develop it?

@roman-vanesyan
Copy link
Collaborator Author

Yes, sure, do what ever you'd like to with it.

@sangdth
Copy link

sangdth commented Aug 11, 2018

Any update about this? I'm looking forward.

@shadowspawn
Copy link
Collaborator

Closing this WIP, see issue #666 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants