-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Modernize codebase to ES6 #661
Conversation
…ad use arrow functions. Replace all functions with arrow functions, where necessary.
I would like to cast a vote on the plan to switch to jest. |
@vanesyan Could you tell us about your future development schedule? |
Currently the branch contains only convertion of the codebase to es6 and separation of classes per file, everything working pretty well on Node.js 8+. The first thing we should recognize which minimal version of Node.js we support. |
Also, the plan was to incrementally improve the codebase. Currently commander consists of set of hacks to support different cases IMHO, we should minimize such a things and canonize most of parts of commander. |
Another one part of the plan was to implement critical futures people request for a long time, for instance long awaited future like control the flow of processing of required options, arguments. |
Probably, we shouldn't merge this pr into master, rather we should create |
@vanesyan Thank you for your reply. I also have some suggestions for improvement. So I would like to do this with this new branch if I am going to fix it. |
Yes, sure, do what ever you'd like to with it. |
Any update about this? I'm looking forward. |
Closing this WIP, see issue #666 instead. |
No description provided.