-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
express-session
as a dependency/peerDependency is missing
#380
Comments
Yeah, that is fair. I updated the readme to be clear about this requirement but it would help at the package level too. I was debating making it a peer dependency given other session store packages not doing it (even though they were using it) as it never makes sense to use this package without also using express-session. But I'd rather have NPM (and others) at least warn about this as you've found out. Thanks for reporting. |
Released in v7.0.1 |
Thanks a lot @wavded |
With the last version (7.x), we encounter this error:
connect-redis tried to access express-session, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
express-session
should be declared as a dependency or a peerDependency, since the package is imported.connect-redis/index.ts
Line 1 in 3230e28
The text was updated successfully, but these errors were encountered: