Support Teacup #104
Merged
Support Teacup #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hurrymaplelad please rebase your commits and include promise support |
|
god, this is frustrating |
hurrymaplelad
force-pushed
the
teacup
branch
2 times, most recently
from
89303ca to
d2064d0
Compare
|
Rebased & added promise support. Should be good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descendant of coffeecup, requested in #103.
Disabling caching currently won't work for helpers since they use the Node require cache. I could diff and purge the whole
module.cacheafter each render, but that feels janky. Better to just use node-supervisor and friends in development.