Added search and replace for invalid characters in branch name. A '\'… #815
Conversation
…, '/', and ':', will be replaced with '_'.
| @@ -20,6 +20,8 @@ else | |||
| if [ "$BRANCH" = "master" ]; then | |||
| FILENAME=$ARCHIVE_NAME.$VERSION.zip | |||
| else | |||
| # govern against invalid path characters | |||
There was a problem hiding this comment.
Please follow the indentation of the other code.
There was a problem hiding this comment.
The indentation is exactly the same in my IDE, IntelliJ.
There was a problem hiding this comment.
@DarekDan
Look like your IDE uses 2 spaces to represent a tab, and converts a tab into two space. Would you change the tabs around into 4 spaces?
| @@ -20,6 +20,8 @@ else | |||
| if [ "$BRANCH" = "master" ]; then | |||
| FILENAME=$ARCHIVE_NAME.$VERSION.zip | |||
| else | |||
| # govern against invalid path characters | |||
| BRANCH=$(echo "$BRANCH" | sed -r 's/[\/\\\:]+/_/g') | |||
There was a problem hiding this comment.
As g option is specific, is it necessary to use + in the regex?
If + can be omitted, -r can be omitted too.
There was a problem hiding this comment.
It does not hurt, and covers all future scenarios.
There was a problem hiding this comment.
@DarekDan
Less code, less bugs.
For example, bsd sed doesn't have the -r option. If the extended regex is required, we have to write more code to work around.
…, '/', and ':', will be replaced with '_'.