Support mocha reporters #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 5, 2012 22:48
Creates extra events for 'console-methodName' where `methodName` is log, error, info etc.
|
Ok this is pretty badass, looking forward to seeing this merged in |
|
This may work with component.js - but seems to fail without it. Perhaps it's just older, but it just seems like there are raw |
|
Yes, but all that's then needed is a compiled version. Component can generate standalone builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the API significantly. Instead of handling events on the client and saving info into mochaResults, we serialize all the event information and send it to the reporter as JSON. By using
jssnit can send circular references fine and also re-construct the prototype chains properly on arrival.The upshot of the API change is that you can use any of the standard mocha reporters. Here is a demo of browser side tests running with the
specreporter:Note that the timing at the end is sadly completely erroneous, but could be fixed if the timing was done in the runner and not in the reporter.