Makefile: improve compatibility with BSD make. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Makefile contained a couple instances of GNU make specific syntax. This caused a build error when using BSD make. This was reported in Issue 29 #29 BSD make wasn't setting $^ in the mon target, so the object files weren't being listed in the compile command. This is fixed by replacing $^ with $(OBJ). BSD make was outputting the object files to the current directory instead of the src and deps directories as expected due to the way the generic .c to .o rules were written. This patch rewrites that rule so that BSD make outputs the object files to the proper sub-directory. Tested on NetBSD and Linux with GNU make 3.82 and BSD make 20110606.
tj
added a commit
that referenced
this pull request
Dec 1, 2013
Makefile: improve compatibility with BSD make.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile contained a couple instances of GNU make specific
syntax. This caused a build error when using BSD make. This
was reported in Issue 29 #29
BSD make wasn't setting $^ in the mon target, so the object files$^ with $ (OBJ).
weren't being listed in the compile command. This is fixed by
replacing
BSD make was outputting the object files to the current directory
instead of the src and deps directories as expected due to the
way the generic .c to .o rules were written. This patch rewrites
that rule so that BSD make outputs the object files to the proper
sub-directory.
Tested on NetBSD and Linux with GNU make 3.82 and BSD make 20110606.