Notification not showing on Linux when a title is provided

[naholyr]

The issue

When using mocha --growl on my Linux distribution using notify-send, notifications do not appear.

I've looked into the executed command, and it tries to run notify-send '-i' '/…/node_modules/mocha/images/ok.png' '--hint=int:transient:1' 'Passed' '' '4 tests passed in 1236ms' which, when run directly into my terminal, responds with Invalid number of options. The empty string in the middle got my attention, and it seems to be actually the cause of this bug as it works fine without it.

The solution?

In the code I find those lines:

		case 'Linux':
			if (options.title) {
				args.push(options.title)
				args.push(cmd.msg)
				args.push(msg.replace(/\\n/g, '\n'))
			} else {
				args.push(msg.replace(/\\n/g, '\n'))
			}

I don't get why cmd.msg AND msg.replace(…) are both added while notify-send only takes one body argument (see below). It works fine when I remove args.push(cmd.msg), which is my proposed solution (but there may be side-effects?).

Environment information

notify-send --version

notify-send 0.7.6

lsb_release -a

No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.3 LTS
Release:	16.04
Codename:	xenial

notify-send --help

Usage:
  notify-send [OPTION...] <SUMMARY> [BODY] - create a notification

Help Options:
  -?, --help                        Show help options

Application Options:
  -u, --urgency=LEVEL               Specifies the urgency level (low, normal, critical).
  -t, --expire-time=TIME            Specifies the timeout in milliseconds at which to expire the notification.
  -a, --app-name=APP_NAME           Specifies the app name for the icon
  -i, --icon=ICON[,ICON...]         Specifies an icon filename or stock icon to display.
  -c, --category=TYPE[,TYPE...]     Specifies the notification category.
  -h, --hint=TYPE:NAME:VALUE        Specifies basic extra data to pass. Valid types are int, double, string and byte.
  -v, --version                     Version of the package.

[naholyr]

Additional info about environment

dpkg -S notify-send

libnotify-bin: /usr/bin/notify-send
libnotify-bin: /usr/share/man/man1/notify-send.1.gz

dpkg -s libnotify-bin

Package: libnotify-bin
Status: install ok installed
Priority: optional
Section: utils
Installed-Size: 69
Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
Architecture: amd64
Source: libnotify
Version: 0.7.6-2svn1
Depends: libc6 (>= 2.3.4), libglib2.0-0 (>= 2.26), libnotify4 (>= 0.7.3)
Description: sends desktop notifications to a notification daemon (Utilities)
 A library that sends desktop notifications to a notification daemon, as
 defined in the Desktop Notifications spec. These notifications can be
 used to inform the user about an event or display some form of
 information without getting in the user's way.
 .
 This package contains the binary which sends the notification.
Original-Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>

[hmshwt]

@naholyr I am facing the same issue while using node-growl with Mocha on

Ubuntu 17.10
notify-send version 0.7.7
libnotify-bin version 0.7.7-2.

I confirm that notify-send responds with 'Invalid number of options' because of an extra argument '' inserted by cmd.msg . I would like to send a PR.

[deiga]

@hmshwt Feel free to make a PR

[deiga]

Fixed in 1.10.4