Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added margin_left style #32

Merged
merged 2 commits into from
Jul 3, 2015
Merged

Added margin_left style #32

merged 2 commits into from
Jul 3, 2015

Conversation

erwanlr
Copy link
Contributor

@erwanlr erwanlr commented Apr 18, 2013

Possibility to add a left margin, default ''

@nateberkopec
Copy link
Collaborator

Can you rebase this with master to fix your whitespace formatting issues?

@erwanlr
Copy link
Contributor Author

erwanlr commented Jun 30, 2015

Merged with the current master :)

Furthermore, it would be recommended to update the .rvmrc which ask for ruby 1.8.7 :O

Maybe also setup Travis to track builds/PR introducing issues and use rubocop for code style ? (I know, that's a lot, but it can only do good ;))

@nateberkopec
Copy link
Collaborator

Yeah we should just delete the .rvmrc.

I can't setup Travis because @tj owns the repo (and I think would have to create an organization in order to give me those privileges?) though I agree it would be valuable. So chalk that up as unlikely, unfortunately.

@nateberkopec
Copy link
Collaborator

Thanks for contributing 👯

nateberkopec added a commit that referenced this pull request Jul 3, 2015
@nateberkopec nateberkopec merged commit 8316f40 into tj:master Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants