Use the older way of converting to hash #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nateberkopec |
|
Pushed in 1.7.3 |
|
Good catch @vivekbisen 👍 |
asedge
pushed a commit
to NARKOZ/gitlab
that referenced
this pull request
Apr 25, 2017
The latest version of `terminal-table` is compatible with ruby 2.0 again, see tj/terminal-table#80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest version of this gem,
.to_hwas used to convert to Hashes from Array of arrays. This method was implemented in ruby version 2.1 and above. Since this is a legacy gem, we should use a method that goes way back.This PR fixes the issue for those who use this gem in applications that don't support ruby 2.1 yet. Also, if this gem is installed via brew in MacOS, it breaks coz brew uses ruby 2.0.0