Fix issues with next tick never running #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling v8::Function::Call directly for async callbacks leads to very odd behavior in some circumstances, specifically the next tick of the event loop seems to get stuck. After much digging, I found references to this being a "known" issue, and the proper way to call async functions in JS is to use the node::MakeCallback helper, or the Nan equivalent. In some cases, we also use the Nan::Callback object as a helper for managing JS callbacks. KNOWN ISSUES: On node <v6, it seems that exceptions thrown from JS when called from .NET do NOT propagate back to .NET correctly. Instead, they terminate the JS process. This appears to be a known limitation of using the MakeCallback method, with no easy workarounds. On 6.4.0, this test does pass, which indicates the issue has been fixed in node.
The previous fixes to use Nan::MakeCallback had the side effect of swallowing exceptions on Node <v6, which was a regression. To retain that behavior, we revert the JS execution calls to using Nan::Call instead of Nan::MakeCallback, and instead explicitly kick the next tick with a no-op function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #325