Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to django 4.2.14 (from 2.2.20) #81

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aarushtools
Copy link
Member

@aarushtools aarushtools commented Jul 9, 2024

Rationale

  • Django 2.2 has been eol for a long time, while 4.2 has extended support until early 2026

Changes

  • update django to 4.2 and other libraries such as social-auth-app-django so that they're compatible with the new version
  • change code so that it's compatible with django 4.2

Important

#79 will need to have merge conflicts resolved after this PR is merged

@aarushtools aarushtools force-pushed the upgrade-django branch 4 times, most recently from 9391fdc to ccce200 Compare July 9, 2024 22:27
@aarushtools aarushtools marked this pull request as ready for review July 9, 2024 22:30
@coveralls
Copy link

coveralls commented Jul 9, 2024

Coverage Status

coverage: 53.365% (+0.2%) from 53.129%
when pulling fc7303f on aarushtools:upgrade-django
into f908c9a on tjcsl:master.

Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Just noticed some stuff while looking through...
About #79, I'm a little bit busy this week, and I still need to upgrade Flask on that PR. Seeing as this PR is almost done, I would prefer to get this PR merged before mine :)

manager/director/apps/users/views.py Outdated Show resolved Hide resolved
manager/director/apps/docs/utils.py Show resolved Hide resolved
manager/Pipfile Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants