Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(printing): attribute error when requesting print job #1715

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(printing): attribute error when requesting print job #1715

merged 1 commit into from
Sep 5, 2024

Conversation

aarushtools
Copy link
Member

Proposed changes

  • replace all instances of PRINTING_PAGES_LIMIT with PRINTING_PAGES_LIMIT_STUDENTS and PRINTING_PAGES_LIMIT_TEACHERS and logic where appropriate

Brief description of rationale

This will fix the attribute error when requesting a print job (i accidentally used the old version of this code when I was resolving the merge conflicts for the original PR #1666 )

@aarushtools aarushtools requested a review from a team as a code owner September 4, 2024 20:09
@coveralls
Copy link

Coverage Status

coverage: 79.358% (-0.003%) from 79.361%
when pulling a956f63 on aarushtools:printing-fix
into e5e51f2 on tjcsl:dev.

@alanzhu0 alanzhu0 merged commit 8cb7791 into tjcsl:dev Sep 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanzhu0 alanzhu0 alanzhu0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarushtools @coveralls @alanzhu0