Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): add ios pwa loading screen #1716

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

aarushtools
Copy link
Member

Proposed changes

  • add a loading screen to ios when opening as a pwa

Brief description of rationale

  • makes it look more native since there won't be a white screen for a few seconds when opening

Video of what it looks like

@coveralls
Copy link

coveralls commented Sep 8, 2024

Coverage Status

coverage: 79.343% (+0.005%) from 79.338%
when pulling 779e2f8 on aarushtools:pwa-loadscreen
into 8cb7791 on tjcsl:dev.

@aarushtools aarushtools marked this pull request as ready for review September 8, 2024 16:58
@aarushtools aarushtools requested a review from a team as a code owner September 8, 2024 16:58
@krishnans2006
Copy link
Member

Looks amazing, great work! Just a quick question (not an official review): where'd you get that list of required resolutions? Feels slightly excessive to me...

@alanzhu0
Copy link
Member

alanzhu0 commented Sep 8, 2024

Looks good! Small thing - can you make the ion logo background color match the blue overall loading screen background?

@aarushtools
Copy link
Member Author

aarushtools commented Sep 8, 2024

Looks amazing, great work! Just a quick question (not an official review): where'd you get that list of required resolutions? Feels slightly excessive to me...

Yeah it is but unfortunately you have to put a link tag for each device on the apple spec. I used pwa-asset-generator and it auto generates most of this. Also, all the tags are abstracted away in a separate file (and images in a separate folder) so 1-2 more lines to support something like the iphone 4 shouldn't really make a difference if we want to match 100% of the apple spec

Looks good! Small thing - can you make the ion logo background color match the blue overall loading screen background?

Sorry I didn't notice, it should be fixed now 👍

@alanzhu0 alanzhu0 merged commit 9a1872e into tjcsl:dev Oct 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants