Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escapeString to handle parameters that contain spaces. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MadManMarkAu
Copy link

escapeString will escape a single parameter containing spaces into a string CasparCG will interpret as being multiple parameters. If a parameter contains a space, it should be surrounded with quote marks.

@tjenkinson
Copy link
Owner

Thanks for this. I agree that this makes sense but I think either it should be another method which will escape and quote (if needed), or a second parameter which would default to false, but if true add the quotes (if necessary). That way it won't break code for people that have already wrapped this function call in quotes, which could result in duplicate quotes, so it's backwards compatible. If you add this change I'll merge it in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants