Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the required version of Sungrow-Modbus to include PyCrypto repla… #38

Merged
merged 3 commits into from
Oct 16, 2021

Conversation

tjhowse
Copy link
Owner

@tjhowse tjhowse commented Oct 15, 2021

…cement.

This is blocked on: rpvelloso/Sungrow-Modbus#7

This is a fix for #37

@pep8speaks
Copy link

pep8speaks commented Oct 15, 2021

Hello @tjhowse! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-15 23:56:13 UTC

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #38 (448672c) into master (96da28f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files           6        6           
  Lines         841      841           
=======================================
  Hits          806      806           
  Misses         35       35           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
modbus4mqtt/version.py 100.00% <100.00%> (ø)
tests/test_mqtt.py 97.40% <0.00%> (-1.16%) ⬇️
tests/test_modbus.py 97.14% <0.00%> (+2.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96da28f...448672c. Read the comment docs.

@tjhowse tjhowse merged commit 5b84767 into master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants