-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow single dot to return entire payload value #29
Conversation
@tjjfvi understandably probably a low use-case, but could this be merged? |
@derekantrican Could you test this locally? From a brief look, there's a syntax error on lines 50 and 52; conditionals need to end with a Sorry for the very belated response; I must've missed the notification before. |
Thanks for the callout! I think I pushed the appropriate changes (as you can probably tell - I'm not super familiar with Python, just enough to get around). I'll look into testing it locally tomorrow. I'm fairly unfamiliar with Python & Raspberry Pi, but I'll give it a shot. I found https://docs.octoprint.org/en/master/development/index.html last night so that may help |
Same here, to be honest :)
It's been a while since I've touched octoprint plugins, so I don't fully recall what the process was, and I don't know how it might've changed in the last 2 years. That said, I'm pretty sure that link is for working on octoprint itself, not plugins. Based on my recollection and the plugin tutorial, it seems like you can clone the git repo into |
Should be released in v1.4.0, though I'm not sure I remembered how to publish a version correctly, so let me know if it doesn't show up (though make sure to clear the plugin cache first). |
Yup! Got the notification that 1.4.0 is available! I'm going to skip it though because I still have the changes locally for #40 and am going to hold on to those until it's merged :) |
Allow "." to return the entire payload. This is useful for plugins like https://github.com/derekantrican/OctoPrint-ngrok that don't send a json/dict event payload and instead just send a single argument