Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hooks work on Windows #4

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Make hooks work on Windows #4

merged 1 commit into from
Dec 22, 2022

Conversation

kiview
Copy link
Contributor

@kiview kiview commented Sep 15, 2021

Currently, this bash script will be rendered as commit hook script on Windows:

#!/bin/sh -

`dirname "$0"`\git-hooks\pre-commit

The Windows path separators are unwanted in this case, since bash included in Git, which is used to execute the script, won't interpret them as path separators, but as escape characters.

This PR replaces the platform-dependent path separator with / since the script will be executed with bash on Windows as well.

Replace platform-dependent path separator with `/`, since the script will be executed with bash on Windows as well.
@bsideup
Copy link

bsideup commented Dec 22, 2022

Hi @tjni, any chance you could PTAL? 🙌

@tjni tjni merged commit 52a7b86 into tjni:master Dec 22, 2022
@tjni
Copy link
Owner

tjni commented Dec 22, 2022

I'm sorry, guys! Life events, blah blah. Thank you both for looking into this.

@bsideup
Copy link

bsideup commented Dec 23, 2022

@tjni wooo! Thank you for merging it, and no problem at all. The plugin is great and does its job, we are a very happy user of it at @AtomicJar 🙌

@kiview kiview deleted the patch-1 branch January 4, 2023 12:04
@eddumelendez
Copy link

Thanks for the release @tjni! but looks like it is not available via maven central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants