🐛 Remove constructor from scroll hooks to support Angular 8 (#477)

* 🐛 Remove constructor from scroll hooks to support Angular 8 * 🎨
tjoskar · Aug 27, 2020 · 12f0dc2 · 12f0dc2
1 parent 78512a9
commit 12f0dc2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/src/scroll-hooks/__test__/hooks.test.ts b/src/scroll-hooks/__test__/hooks.test.ts
@@ -1,12 +1,17 @@
 import { ScrollHooks } from '../hooks';
 
 describe('isVisible', () => {
-  const getWindow = () =>
-    ({
-      innerHeight: 1000,
-      innerWidth: 1000,
-    } as any);
-  const hooks = new ScrollHooks(getWindow);
+  class Sut extends ScrollHooks {
+    constructor() {
+      super();
+      this.getWindow = () =>
+        ({
+          innerHeight: 1000,
+          innerWidth: 1000,
+        } as any);
+    }
+  }
+  const hooks = new Sut();
 
   const generateElement = (top: number, left: number, height = 300, width = 300): any => ({
     getBoundingClientRect: () => ({

diff --git a/src/scroll-hooks/hooks.ts b/src/scroll-hooks/hooks.ts
@@ -5,14 +5,9 @@ import { Attributes } from '../types';
 import { Rect } from './rect';
 
 export class ScrollHooks extends SharedHooks<Event | string> {
-  private readonly getWindow: () => Window;
+  protected getWindow = () => window;
   private readonly scrollListeners = new WeakMap<any, Observable<any>>();
 
-  constructor(getWindow = () => window) {
-    super();
-    this.getWindow = getWindow;
-  }
-
   getObservable(attributes: Attributes<Event | string>): Observable<Event | string> {
     if (this.skipLazyLoading()) {
       return of('load');