Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit testcases for useToastsInternal #247

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

anjumnnit
Copy link
Contributor

Closes #130

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to docs/code comments)

Checklist:

  • The commit message follows our adopted guidelines
  • Testing has been done for the change(s) added (for bug fixes/features)
  • Relevant comments/docs have been added/updated (for bug fixes/features)

I would really appreciate if you review my PR as hacktoberfest'24 is coming to an end.

@anjumnnit
Copy link
Contributor Author

@tjtanjin It's my last PR you helped me a lot for my other PR's kindly review this PR too so that I can complete the hacktoberfest'24 Challenge :)

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @anjumnnit, there're warnings raised by the Lint stage for the use of the any type 🥹

@anjumnnit
Copy link
Contributor Author

Hey @anjumnnit, there're warnings raised by the Lint stage for the use of the any type 🥹

you can review now....😢

Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tjtanjin tjtanjin merged commit c8d9946 into tjtanjin:main Oct 29, 2024
11 checks passed
@anjumnnit
Copy link
Contributor Author

anjumnnit commented Oct 29, 2024

LGTM

Tysmmm😭.....I really liked your project love to contribute more and connect with you.

RAVEYUS pushed a commit to RAVEYUS/react-chatbotify that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add unit test cases for useToastsInternal hook
2 participants