Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mousescroll only in horizontal direction. #11

Closed
wants to merge 1 commit into from
Closed

Support for mousescroll only in horizontal direction. #11

wants to merge 1 commit into from

Conversation

Avinash-Bhat
Copy link

Hi,
I've created a small fix(line: 231-232) to allow the scrolling only in horizontal direction, as that is the way it should it be.
Signed-off-by: Avinash nashpapa@gmail.com

Signed-off-by: Avinash <nashpapa@gmail.com>
@tkahn
Copy link
Owner

tkahn commented Jul 29, 2012

Hi!

Before I merge this fix, could you please explain some more what was the problem and why you needed to make the fix. I just want to know if this is something that all users want or if it's a feature that is specific to your needs.

/Thomas

@Avinash-Bhat
Copy link
Author

Thomas,

This is not a fix for any problem. I thought it should scroll only in horizontal direction, bcoz, while using a touchpad - as in laptop, or in touch-phones, the current functionality is slightly annoying, as the mouse may enter the scrolling container as a part of scrolling the whole document, and the user will be forced to move mouse/pointer to a place outside of the container. so, it would have been cool if it just scrolled horizontally only.
But i have found that while using desktop PC, existing functionality was better. So i wonder you could include this fix as a part of a new option to enable scrolling horizontally only (that way the end programmer can choose to enable/disable horizontal scrolling).

Thanks.

@tkahn
Copy link
Owner

tkahn commented Jul 30, 2012

Hi!

Yes, I was thinking exactly along these lines. When I use a desktop mouse with a scroll wheel I want to be able to use the vertical scrolling of the wheel to control the scrolling. I think your suggestion (adding an option to lock the scrolling to a certain axis) is excellent!

Thanks for your feedback!

/Thomas

@ghost ghost assigned tkahn Jul 30, 2012
@tkahn
Copy link
Owner

tkahn commented Sep 11, 2012

To fix this and still give people that want all mousewheel directions I have changed the parameter mousewheelScrolling from boolean to string. Now you can use the values "upDown", "leftRight", "allDirections" or empty (no mousewheel scrolling). Using upDown you lock the mousewheel scrolling to the y-axis and leftRight to the x-axis. Using allDirections it doesn't matter which direction you use and if you leave the parameter out or supply an empty string there's no scrolling at all.

Will be included in the next update.

/Thomas

@Avinash-Bhat
Copy link
Author

Thanks.

@tkahn
Copy link
Owner

tkahn commented Sep 12, 2012

Implemented in release 1.3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants