Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginnings of gamerzilla support. #412

Open
wants to merge 848 commits into
base: master
Choose a base branch
from
Open

Beginnings of gamerzilla support. #412

wants to merge 848 commits into from

Conversation

dulsi
Copy link

@dulsi dulsi commented Jul 10, 2020

Gamerzilla is an open source trophy/achievement system I've been building. The web display piece is currently handled by a plugin for Hubzilla. Additional implementations could be made in the future. LibGamerzilla is a library for games to upload when trophies are acquired and progress. To avoid having to enter your Hubzilla url, username, and password in every game, the library was designed with a game launcher in mind.

This pull request implements the listener and communication with Hubzilla. It is mainly to seek feedback on the idea. The plan is for Gamehub to get the game image from LibGamerzilla and be able to display trophies.

Right now the settings are on the Collections page which probably isn't the right place.

tkashkin and others added 30 commits June 22, 2019 04:50
Show default icons for games in list and details
Update Humble Trove parsing (tkashkin#32)
Currently translated at 97.5% (309 of 317 strings)

Translation: GameHub/Translations
Translate-URL: https://hosted.weblate.org/projects/gamehub/translations/nb_NO/
Currently translated at 100.0% (319 of 319 strings)

Translation: GameHub/Translations
Translate-URL: https://hosted.weblate.org/projects/gamehub/translations/nl/
Currently translated at 97.5% (311 of 319 strings)

Translation: GameHub/Translations
Translate-URL: https://hosted.weblate.org/projects/gamehub/translations/nb_NO/
Currently translated at 100.0% (319 of 319 strings)

Translation: GameHub/Translations
Translate-URL: https://hosted.weblate.org/projects/gamehub/translations/nb_NO/
Add actions for selected games (tkashkin#262)
Batch tag editing for selected games
Currently translated at 100.0% (326 of 326 strings)

Translation: GameHub/Translations
Translate-URL: https://hosted.weblate.org/projects/gamehub/translations/nl/
Currently translated at 100.0% (326 of 326 strings)

Translation: GameHub/Translations
Translate-URL: https://hosted.weblate.org/projects/gamehub/translations/nb_NO/
`GameFSOverlaysDialog` will now show warning or error depending on 
game's `install_dir` (tkashkin#254)
Currently translated at 100.0% (329 of 329 strings)

Translation: GameHub/Translations
Translate-URL: https://hosted.weblate.org/projects/gamehub/translations/nl/
Currently translated at 99.7% (328 of 329 strings)

Translation: GameHub/Translations
Translate-URL: https://hosted.weblate.org/projects/gamehub/translations/nb_NO/
Currently translated at 31.9% (105 of 329 strings)

Translation: GameHub/Translations
Translate-URL: https://hosted.weblate.org/projects/gamehub/translations/zh_CMN-HANT/
Currently translated at 100.0% (339 of 339 strings)

Translation: GameHub/Translations
Translate-URL: https://hosted.weblate.org/projects/gamehub/translations/nl/
Currently translated at 98.2% (333 of 339 strings)

Translation: GameHub/Translations
Translate-URL: https://hosted.weblate.org/projects/gamehub/translations/nb_NO/
Reorder CompatTools
Clear IGDB data cache for game when games is renamed (tkashkin#274)
@dulsi
Copy link
Author

dulsi commented Jul 10, 2020

@dulsi
Copy link
Author

dulsi commented Jul 19, 2020

I've added support to allow you to configure gamerzilla name for a game and then display image and achievement information.

@dulsi
Copy link
Author

dulsi commented Jul 30, 2020

Would it help to show a screenshot?
smalltrek_gamehub

@Lucki
Copy link
Contributor

Lucki commented Jul 30, 2020

There's currently some major refactoring going on so be patient cause that will take a while with the current manpower. But I can't see why this won't find it's way into GameHub eventually as it's already supporting multiple achievement systems.

Some thoughts about gamerzilla itself:

  • The naming could be more about the feature it provides than the service it comes from. Gamerzilla gives no clue what it does besides being gaming related and related to Hubzilla which I've never heard of before is just one of the implementations. (Example: AStats.nl is about statistics of (steam) achievements)
  • While being independent and able to host your own service to connect to it's IMHO good to provide a default address. Make a small, good looking (!) website where interested users can easily register/login (steam, openid, whatever) and connect to and show their profile with achievements to others. A minimal example what could be done, a show off to others.
    Yes, this goes against the decentral thing but often people just want to try something out quickly or don't have an own server at hand to set it up properly.

Some thoughts about the implementation:

  • You're referring specifically to a "Hubzilla URL". As Hubzilla is only one of the implementations wouldn't a more generic name be more suitable?
  • You're adding a gamerzilla name, when do the game name and the gamerzilla name differ? Can't they be the same? I would rather not go through my entire collection and manually add the gamerzilla name to all of them.

@dulsi
Copy link
Author

dulsi commented Aug 2, 2020

I agree that setting the gamerzilla name manually is not good. It was more proof of concept. It's not really possible to make them the same.

I've add a callback function to LibGamerzilla. It will give the gamerzilla name and the game's name. It should then be possible to setup the association automatically. If I'm in the GameHub.Application class, how can I get to the game object to update it?

@tkashkin
Copy link
Owner

tkashkin commented Aug 2, 2020

@dulsi

If I'm in the GameHub.Application class, how can I get to the game object to update it?

Not sure if that's what you want, but there are a few places in Application that access games by id: https://github.com/tkashkin/GameHub/blob/dev/src/app.vala#L532

@dulsi
Copy link
Author

dulsi commented Aug 6, 2020

It will now automatically set the gamerzilla name when you run the game.

@dulsi
Copy link
Author

dulsi commented Oct 30, 2020

Any word on merging this?

@tkashkin
Copy link
Owner

@dulsi no plans right now.
I'll think about it after current refactoring is finished.

Current achievements (Steam, GOG) should probably be abstracted into AchievementProviders before merging this, similarly to current DataProvider and ImagesProvider.
This should also allow to implement other achievement providers like RetroAchievements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.