Fix ISBN.ten method to handle 10 digit isbns starting with 979 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmhiyoko
changed the title
|
@mmhiyoko thanks for bringing this flaw to my attention. I was a bit myopic in my original design not considering this use case. I'll try to review this PR this weekend and issue a new release if everything works out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a 10 digit isbn starting with 979 to the current ISBN.ten method, it throws a No10DigitISBNAvailable exception.
However, 10 digit isbns starting with 979 are valid according to the specifications, and there are actual books that have them.
Example: https://www.goodreads.com/book/show/1038257.Tirai_Menurun.
I have made the fixes in this Pull Request, so please review.