Cleanup library build, make static library optional #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build the shared library on Linux the same way as on Windows, i.e. compile the sources individually for static and shared libs. This removes the "FLANN_STATIC" compile definition from the shared library build (confusing, albeit without any effect on Linux), and avoids any linker trickery. Also allow to disable build and installation of the static libraries completely, as these are often unwanted on Linux distributions. Fixes flann-lib#498. See flann-lib#369.
|
How does one activate the generation of the static library after this changes? I'm using cmake-gui and could not find a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the shared library on Linux the same way as on Windows, i.e. compile the sources individually for static and shared libs.
This removes the "FLANN_STATIC" compile definition from the shared library build (confusing, albeit without any effect on Linux), and avoids any linker trickery.
Also allow to disable build and installation of the static libraries completely, as these are often unwanted on Linux distributions.
Fixes flann-lib#498.
See flann-lib#369.