Drop getconf check in TestGetPresent #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the assumption that `getconf _NPROCESSORS_CONF` returns the number of CPUs in `/sys/devices/system/cpu/present` is not always true on all systems. Inspecting the code of glibc's getconf implementation it seems the value returned by `getconf _NPROCESSORS_CONF` is the total number of `cpuN` directories found in `/sys/devices/system/cpu` while `numcpus.GetPresent` reads `/sys/devices/system/cpu/present`. Thus, drop the check to avoid failing tests where this might not be true (such as on some ppc64 systems. Fixes #15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the assumption that
getconf _NPROCESSORS_CONFreturnsthe number of CPUs in
/sys/devices/system/cpu/presentis not alwaystrue on all systems.
Inspecting the code of glibc's getconf implementation it seems the value
returned by
getconf _NPROCESSORS_CONFis the total number ofcpuNdirectories found in
/sys/devices/system/cpuwhilenumcpus.GetPresentreads/sys/devices/system/cpu/present. Thus, dropthe check to avoid failing tests where this might not be true (such as
on some ppc64 systems.
Fixes #15