-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite parse_time so it understands time zones and microseconds #152
Conversation
Any progress on this PR? I just spent an hour on a timezone problem before I realized that gpxpy just ignores the timezone information. |
1fbbbc8
to
42edb05
Compare
Would it be possible to merge and release this as some point? Would be really helpful to support time zones 👍 |
Yes, I plan to merge this pull request. Before diving in the code @Zverik do you think this is now the final version or you have more things to commit here? |
I think that's final: it's on par with the version we use in our company. |
Thanks for merging and releaseing! |
Fixes #83, #114 and #148.
I decided to go with a precompiled regular expression. It should be fast, since there are no
+
or*
special characters in it. Tested in Python 2.7 and 3.6.