Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement API to check Canvas user existence #252

Closed
lsloan opened this issue Nov 30, 2021 · 6 comments · Fixed by #247
Closed

implement API to check Canvas user existence #252

lsloan opened this issue Nov 30, 2021 · 6 comments · Fixed by #247
Assignees

Comments

@lsloan
Copy link
Member

lsloan commented Nov 30, 2021

Related to #19 and #221.

Given a single user's login_id, return an HTTP status code and data to indicate whether a Canvas account exists for the user.

  • Exists: HTTP 200; data including login ID, given name, surname, and email address (additional data may be helpful). (NB: Email address is not available to the admin user token with its current set of permissions, but it is not important.)
  • Nonexistent: HTTP 404; data should contain an error message and include the requested login ID for confirmation and debugging purposes.
@lsloan lsloan self-assigned this Nov 30, 2021
@lsloan

This comment has been minimized.

@ssciolla

This comment has been minimized.

@pushyamig

This comment has been minimized.

@ssciolla

This comment has been minimized.

@pushyamig
Copy link
Contributor

The current tool is showing the first and lastname along with email address. Here is the API response from canvas when you look up user

[{"id":605615,"name":"FacebookCCM4 Mailinator","created_at":"2020-06-25T17:44:32-04:00","sortable_name":"Mailinator, FacebookCCM4","short_name":"FacebookCCM4 Mailinator","sis_user_id":"facebookccm4@mailinator.com","integration_id":"112760453749885@facebook.com","sis_import_id":null,"login_id":"facebookccm4+mailinator.com"}]

So based on these facts then I feel it is ok to show first and lastname. Screenshot for reference.

Screen Shot 2021-12-01 at 8 11 12 AM

@lsloan
Copy link
Member Author

lsloan commented Dec 1, 2021

Issue description updated.

lsloan added a commit to lsloan/ccm that referenced this issue Dec 20, 2021
@ssciolla: I'm not sure whether I wrote this API entry with the security we would like.  Give me feedback.
lsloan added a commit that referenced this issue Feb 24, 2022
Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants