220 Frontend deps: Material UI and React upgrade #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushyamig
reviewed
Mar 8, 2024
ccm_web/package.json
Outdated
| @@ -84,7 +86,7 @@ | |||
| "@types/passport": "1.0.16", | |||
| "@types/passport-jwt": "4.0.1", | |||
| "@types/react": "17.0.47", | |||
There was a problem hiding this comment.
I see the current version of @types/react:18.2.64 and this will go tandem with react upgrade. is there any reason why this was not updated?
There was a problem hiding this comment.
I think I had it before but I may have lost it trying to merge with the new branch. Just made a commit to update it
|
This PR is working and we discussed the issue that need to be fixed. we will list out them in the Issue Description and work in the upcoming PR. |
pushyamig
approved these changes
Mar 11, 2024
jaydonkrooss
merged commit d8b2e6a
into
tl-its-umich-edu:2024-03-01-dep-update
1 check failed
Closed
pushyamig
pushed a commit
that referenced
this pull request
May 21, 2024
* Upgrade React, Material UI * remove deprecated React 17 methods, fix styling lint errors * package-lock files * drop package-lock files * re-add notistack upgrade, package-lock * fix styled root applied by codemod * update types/react
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #220
Initial package upgrade for MaterialUI, React, react-dom, and notistack.
Followed documentation for v4 to v5 upgrade. Used codemods to help with component upgrades and styling adjustments using emotion.
Multiple styling bugs introduced that will be addressed in another PR (#418)