Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pull neuron ground truths from allen brain #48

Merged
merged 8 commits into from
Jun 16, 2024
Merged

feat: pull neuron ground truths from allen brain #48

merged 8 commits into from
Jun 16, 2024

Conversation

tlambert03
Copy link
Owner

this PR will add a new ground truth: neuronal morphology from allen brain. It does so without depending on allen_sdk (which had a lot of extraneous dependencies that we don't want to take on)

Screen.Recording.2024-06-06.at.8.45.02.PM.mov

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 95.39749% with 11 lines in your changes missing coverage. Please review.

Project coverage is 85.86%. Comparing base (c3d2c72) to head (1d94993).
Report is 1 commits behind head on main.

Current head 1d94993 differs from pull request most recent head 552421e

Please upload reports for the commit 552421e to get more accurate results.

Files Patch % Lines
src/microsim/_draw.py 78.26% 5 Missing ⚠️
src/microsim/allen/_swc.py 97.02% 3 Missing ⚠️
src/microsim/allen/_fetch.py 98.00% 2 Missing ⚠️
src/microsim/util.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   84.92%   85.86%   +0.93%     
==========================================
  Files          47       50       +3     
  Lines        2474     2702     +228     
==========================================
+ Hits         2101     2320     +219     
- Misses        373      382       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 mentioned this pull request Jun 16, 2024
15 tasks
@tlambert03 tlambert03 changed the title feat: neuron ground truth from allen brain [wip] feat: neuron ground truth from allen brain Jun 16, 2024
@tlambert03 tlambert03 changed the title feat: neuron ground truth from allen brain feat: pull neuron ground truths from allen brain Jun 16, 2024
@tlambert03 tlambert03 added the enhancement New feature or request label Jun 16, 2024
@tlambert03 tlambert03 merged commit 96cf3cf into main Jun 16, 2024
12 of 14 checks passed
@tlambert03 tlambert03 deleted the allen branch June 16, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant