Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR effectively undoes #37 and closes #70
while I love the concept of using pint to ensure that quantities and units are handled correctly, it does get annoying to deal with non built-in types throughout the pipeline, where it's not always clear whether you're getting a quantity (which requires special
.magnitude
handling in some cases). Leading to stuff like #70I'm not dropping the dependency on pint yet, so it's still possible to use pint in functions calculating difficult stuff, like fluorophore photon emissions, for example, but there we would simply cast to/from quantities while doing the calculations, but not use them for model fields directly