Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding Identity PSF modality #78

Merged
merged 7 commits into from
Sep 28, 2024

Conversation

federico-carrara
Copy link
Contributor

Added Identity as a new _PSFModality.

  • What: this new modality skips PSF convolution. Hence, the optical image corresponds to the so-called "emission flux".
  • How: by overriding the render() method of _PSFModality. Now it simply multiplies the GT array by the emission spectra for the different channels and FPs.
  • Why: we need this modality in the case the ground truth (FP distrib) is obtained from a light microscopy image (i.e., already convolved by the PSF). For instance, we can have this situation when we want to simulate a spectral image staring from a single frame.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.83%. Comparing base (4869b82) to head (3a26a35).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/microsim/schema/modality/_simple.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   84.87%   84.83%   -0.05%     
==========================================
  Files          47       47              
  Lines        3121     3125       +4     
==========================================
+ Hits         2649     2651       +2     
- Misses        472      474       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tlambert03 tlambert03 added the enhancement New feature or request label Sep 28, 2024
@tlambert03 tlambert03 merged commit ff0c878 into tlambert03:main Sep 28, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants