fix: restrict intensity to positive values after read-noise application #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 84.79% 84.79%
=======================================
Files 47 47
Lines 3156 3156
=======================================
Hits 2676 2676
Misses 480 480 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes a one-line change in
quantize_electrons()method of_Camera.Specifically, it restricts the output to only contain positive values. Negative values can be introduced by the random sampling from the Gaussian distribution simulating the read-out noise.
Motivation
uint. Hence, all negative values are mapped to large numbers in theuintrange (e.g., -1 --> 65534, etc., etc.). As a result, in the casted image we see some extremely bright dots in correspondence of what were the negative values before casting.