End2End Lowering #23

ZihengJiang · 2021-10-19T22:53:32Z

End2End MVP working now.

Transform the dataflow program to non-dataflow format for lowering;
Lower call_dps to explicit memory form;
Support alloc_storage and alloc_tensor for dynamic shape;
Fix the mutator issue with a temporary solution;

Co-Authored-By: Yuchen Jin yuchenj@cs.washington.edu

altanh

mostly LGTM, thanks for the work! some small bugs and nits + thoughts for future

include/tvm/relax/expr_functor.h

altanh · 2021-10-21T20:28:41Z

src/relax/ir/expr_functor.cc

@@ -356,6 +360,7 @@ Var ExprMutator::VisitVarBinding(const VarBinding& binding) {
  //   new_var->checked_type_ = new_value->checked_type_;
  // }

+  Var new_var = binding->var;


why not this->Mutate(binding->var)

Because the lhs of the binding is defining a Var (not reuse it), so we do not need to mutate it.

what if someone wants to write a simple mutator pass that renames each var from x -> my_x?

altanh · 2021-10-21T20:30:26Z

src/relax/ir/expr_functor.cc

@@ -380,7 +385,9 @@ Var ExprMutator::VisitVarBinding(const VarBinding& binding) {
 void ExprMutator::VisitMatchShape(const MatchShape& binding) {
  Expr new_value = this->Mutate(binding->value);
  Expr new_pattern = this->Mutate(ShapeExpr(binding->pattern));
-  Var new_var = Downcast<Var>(this->Mutate(binding->var));
+  Var new_var = binding->var;


same question

src/relax/transform/memory_rewrite.cc

tests/python/relax/test_transform.py

tests/python/relax/test_vm.py

altanh

LGTM just except for the VisitVar in VarBinding 👌

YuchenJin · 2021-10-22T22:45:39Z

Merged, Thanks @altanh for the review!

* call_dps lowering. * Improve shape lowering. * Support alloc_storage for dynamic shape. * implementt ToNonDF to transform program to non-dataflow format. * Fix the mutator issue. * Update build api, an issue occurred. * vm tests can pass. * Support shape tuple in executable seriablization. * Fix for test. * Minor fixes. * Address comments. * Add mutate binding var back. * Visit binding var and fix tests. Co-authored-by: YuchenJin <yuchenj@cs.washington.edu>

* [BugFix] Normalize in mutator when visiting VarBinding and MatchShape * Graph memory planning * Fixes * Translate memory op to vm builtin op * Naive test * Fix importer, use no `iterable`

* call_dps lowering. * Improve shape lowering. * Support alloc_storage for dynamic shape. * implementt ToNonDF to transform program to non-dataflow format. * Fix the mutator issue. * Update build api, an issue occurred. * vm tests can pass. * Support shape tuple in executable seriablization. * Fix for test. * Minor fixes. * Address comments. * Add mutate binding var back. * Visit binding var and fix tests. Co-authored-by: YuchenJin <yuchenj@cs.washington.edu>

YuchenJin and others added 5 commits October 18, 2021 21:10

call_dps lowering.

6e9d315

Improve shape lowering.

79f3354

Support alloc_storage for dynamic shape.

ed3d172

implementt ToNonDF to transform program to non-dataflow format.

2efae17

Fix the mutator issue.

9a1c299

ZihengJiang marked this pull request as draft October 19, 2021 23:02

ZihengJiang and others added 5 commits October 20, 2021 12:37

Update build api, an issue occurred.

7b6e19e

vm tests can pass.

8b45e1f

Support shape tuple in executable seriablization.

c3a1a52

Fix for test.

81be3ff

Minor fixes.

7bf3c83

ZihengJiang marked this pull request as ready for review October 21, 2021 04:27

altanh suggested changes Oct 21, 2021

View reviewed changes

Address comments.

722454d

altanh suggested changes Oct 21, 2021

View reviewed changes

Add mutate binding var back.

a02ef3d

YuchenJin force-pushed the e2e-lowering branch from 6ee030b to a02ef3d Compare October 21, 2021 23:54

Visit binding var and fix tests.

3513000

altanh approved these changes Oct 22, 2021

View reviewed changes

YuchenJin merged commit 8e6ad55 into relax Oct 22, 2021

YuchenJin deleted the e2e-lowering branch October 22, 2021 21:56

MasterJH5574 added a commit to MasterJH5574/tlc-relax that referenced this pull request Apr 8, 2022

[Relax] Hot fix to reuse type and shape in "inference" (tlc-pack#23)

729721f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

End2End Lowering #23

End2End Lowering #23

ZihengJiang commented Oct 19, 2021 •

edited

Loading

altanh left a comment

altanh Oct 21, 2021

YuchenJin Oct 21, 2021

altanh Oct 21, 2021

altanh Oct 21, 2021

altanh left a comment

YuchenJin commented Oct 22, 2021 •

edited

Loading

End2End Lowering #23

End2End Lowering #23

Conversation

ZihengJiang commented Oct 19, 2021 • edited Loading

altanh left a comment

Choose a reason for hiding this comment

altanh Oct 21, 2021

Choose a reason for hiding this comment

YuchenJin Oct 21, 2021

Choose a reason for hiding this comment

altanh Oct 21, 2021

Choose a reason for hiding this comment

altanh Oct 21, 2021

Choose a reason for hiding this comment

altanh left a comment

Choose a reason for hiding this comment

YuchenJin commented Oct 22, 2021 • edited Loading

ZihengJiang commented Oct 19, 2021 •

edited

Loading

YuchenJin commented Oct 22, 2021 •

edited

Loading