feat: distinct colors for each parameter type #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would @sebastiaanspeck @spageektti and @kbdharun have a look at this, please? I cannot add reviewers on this repo. |
spageektti
approved these changes
Oct 13, 2024
|
I do not have a lot of experience with Node, but at least I can see the tests failed |
The test failed due to timeout when fetching the pages, retriggering it should fix the issue usually (like this case). |
sebastiaanspeck
approved these changes
Oct 14, 2024
kbdharun
approved these changes
Oct 14, 2024
|
Hey @owenvoke , would you please have a look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of the issue #397 .
In order to make it work, the theme needs to have defined the colors for
exampleNumber,exampleBool, andexampleString. If it does not have ALL of them, the color defined forexampleTokenwill be used.Checklist
Please review this checklist before submitting a pull request.
npm run test:all)