improve handling of different languages #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of languages is a bit simplistic and makes it hard for foreign users to actually use tldr. To start, if
LANG
was set, it's probable that the user would not want to set this just for the sake of tldr. Additionally, there was no support forLANGUAGES
which goes against the spec.Anyway, this improves things (imo) to be a bit nicer on the user.
Some examples and full resolution pattern (ignoring platform):
The change to how the page itself was rendered was that setting your
LANG=en
would cause my system to attempt the page in ascii regardless of the resolved language, which would throw an error if printing out non-en pages.