feat: stylize text inside backticks when appearing in example description #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah of course, good catch 👍 |
|
Updated to reapply default or user styles, as well as a hardcoded yellow for further emphasis (matching Rust client output). Default style: Custom style: To show I didn't cheat and use "green" as the reset haha |
kyluca
commented
Oct 2, 2024
| @@ -414,6 +417,11 @@ def colors_of(key: str) -> Tuple[str, str, List[str]]: | |||
|
|
|||
|
|
|||
| def output(page: str, plain: bool = False) -> None: | |||
| def emphasise_example(x: str) -> str: | |||
There was a problem hiding this comment.
Opted for a def to avoid a lambda exceeding the line length.
kyluca
commented
Oct 2, 2024
| if '`' in line: | ||
| elements = ['\n', ' ' * LEADING_SPACES_NUM] | ||
|
|
||
| for item in EXAMPLE_SPLIT_REGEX.split(line): |
There was a problem hiding this comment.
Followed the pattern for example commands below, using regex to pull out the substrings using backticks.
owenvoke
approved these changes
Oct 2, 2024
|
I noted the builds are failing due to an unrelated error, so have put up a separate PR to fix them first: #256 |
kyluca
changed the title
kyluca
changed the title
sebastiaanspeck
approved these changes
Oct 4, 2024
kbdharun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #253
Hoping I've understood the brief correctly :)
This change will check for the presence of backticks (`) and replace them with the ANSI escape characters for italics (and a matching reset to close the pairs).
This appears to match the desired output from the Rust CLI from the issue.
Example output:
