Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-magic: add page #10889

Merged
merged 9 commits into from
Oct 10, 2023
Merged

git-magic: add page #10889

merged 9 commits into from
Oct 10, 2023

Conversation

Sadeeed
Copy link
Contributor

@Sadeeed Sadeeed commented Oct 8, 2023 •
edited
Loading

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

Issue: #5137

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 8, 2023
reinhart1010
reinhart1010 requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@reinhart1010 reinhart1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a new page! Here are some of my notes to review.

pages/common/git-magic.md Outdated Show resolved Hide resolved
pages/common/git-magic.md Outdated Show resolved Hide resolved
pages/common/git-magic.md Outdated Show resolved Hide resolved
pages/common/git-magic.md Outdated Show resolved Hide resolved
pages/common/git-magic.md Outdated Show resolved Hide resolved
Sadeeed and others added 5 commits October 10, 2023 00:32
@Sadeeed @reinhart1010
git-magic: update command description
c6361c0 
Co-authored-by: Reinhart Previano Koentjoro <reinhart_previano@yahoo.com>
@Sadeeed @reinhart1010
git-magic: update command description
2c0ef40 
Co-authored-by: Reinhart Previano Koentjoro <reinhart_previano@yahoo.com>
@Sadeeed @reinhart1010
git-magic: update command description
1c2cc49 
Co-authored-by: Reinhart Previano Koentjoro <reinhart_previano@yahoo.com>
@Sadeeed @reinhart1010
git-magic: update command description
c2b7745 
Co-authored-by: Reinhart Previano Koentjoro <reinhart_previano@yahoo.com>
@Sadeeed @reinhart1010
git-magic: update command description
bff25d7 
Co-authored-by: Reinhart Previano Koentjoro <reinhart_previano@yahoo.com>
reinhart1010
reinhart1010 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@reinhart1010 reinhart1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kbdharun kbdharun mentioned this pull request Oct 10, 2023
Closed
73 tasks
kbdharun
kbdharun approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit bdd6684 into tldr-pages:main Oct 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinhart1010 reinhart1010 reinhart1010 approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sadeeed @CLAassistant @reinhart1010 @kbdharun