Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-fresh-branch: add page #10972

Merged
merged 4 commits into from
Oct 14, 2023
Merged

Conversation

Sadeeed
Copy link
Contributor

@Sadeeed Sadeeed commented Oct 13, 2023

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

#5137

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 13, 2023
@Sadeeed
Copy link
Contributor Author

Sadeeed commented Oct 13, 2023

For the maintainers / reviewers
Although I am following the command mnemonic structure, I can not find anything about in the style guide and it'd be great if someone could help me understand it fully so I don't miss any thing in the future.

Thanks

@reinhart1010
Copy link
Collaborator

For the maintainers / reviewers Although I am following the command mnemonic structure, I can not find anything about in the style guide and it'd be great if someone could help me understand it fully so I don't miss any thing in the future.

Thanks

We originally introduce them as a workaround to document commands without long parameter names, such as the ones in the Command Prompt (Windows).

Copy link
Collaborator

@reinhart1010 reinhart1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, here are some reviews from mine.

pages/common/git-fresh-branch.md Outdated Show resolved Hide resolved
pages/common/git-fresh-branch.md Outdated Show resolved Hide resolved
@kbdharun kbdharun mentioned this pull request Oct 14, 2023
73 tasks
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM after @reinhart1010's suggestions.

Sadeeed and others added 2 commits October 14, 2023 12:46
Co-authored-by: Reinhart Previano Koentjoro <reinhart_previano@yahoo.com>
Co-authored-by: Reinhart Previano Koentjoro <reinhart_previano@yahoo.com>
Copy link
Collaborator

@reinhart1010 reinhart1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reinhart1010 reinhart1010 merged commit c595b07 into tldr-pages:main Oct 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants