Skip to content

jj-git: add page #17046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

jj-git: add page #17046

merged 2 commits into from
Jul 3, 2025

Conversation

AgamAgarwal
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): v0.30.0

#17040

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Jun 30, 2025
This was referenced Jun 30, 2025
Merged
Open
dmmqz
dmmqz reviewed Jun 30, 2025
View reviewed changes
@Managor
Copy link
Member

Managor commented Jul 1, 2025

I did a rework of the git page. Could be used as a guidepost for this #17056

icorbrey
icorbrey suggested changes Jul 2, 2025
View reviewed changes
@AgamAgarwal AgamAgarwal requested a review from icorbrey July 3, 2025 03:00
@AgamAgarwal
Copy link
Contributor Author

I did a rework of the git page. Could be used as a guidepost for this #17056

Hey @Managor ,

I compared the jj-git page with the updated git page in #17056. It already has a similar structure. I don't think there are any further changes needed for this.

MachiavelliII
MachiavelliII approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@MachiavelliII MachiavelliII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@Managor Managor merged commit b852893 into tldr-pages:main Jul 3, 2025
4 checks passed
@AgamAgarwal AgamAgarwal deleted the jj-git branch July 5, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmmqz dmmqz dmmqz left review comments

@icorbrey icorbrey icorbrey approved these changes

@Managor Managor Managor approved these changes

@MachiavelliII MachiavelliII MachiavelliII approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AgamAgarwal @Managor @icorbrey @dmmqz @MachiavelliII