-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete maintainers' guide #1897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
Thanks for the reviews. Please don't merge yet, I will add the template messages as discussed in #1878. |
Update: I started adding the template messages in
This hopefully makes In addition, I also removed the ambiguity regarding in the term "maintainer", which was used to mean both "repository collaborator with commit access" and "organization owner". It now means only the former. Again, please review the commits individually to ensure each change makes sense in context. |
Looks ok to me! 👍 Curious as to why the contents of |
No particular reason, I just thought it made sense to present the sequence in the "when --> how --> who" order. But now that I think of it, I also like the fact that this order gives more prominence to the processes and guidelines, than to the people. I think that's important if we want a community that's encourages collaboration and is as self-managing as possible. Besides, the part of the list that is useful for, say, third parties reaching out to the tldr-pages organization, is both linkable via its section header anchor, and equivalent to the listing at https://github.com/orgs/tldr-pages/people, which is public and easily accessible. So I don't see any downsides of that list being at the bottom of the file. Do let me know if you disagree with any of this, though. |
LGTM |
It's really a great job. Thanks~ @waldyrious |
Great, thanks for the reviews guys 👍 I'll go ahead and merge this now, given the multiple approvals (and no objections). Later on I will submit small changes as a separate PR, which are needed to account for the limitations I found while performing role changes at the organization level. More details in this comment. |
This PR completes the work initiated in #1839, and closes #1209. /cc @agnivade, @sbrl. I'd also love to get feedback from @jsonbruce and @pxgamer, who are our newest collaborators since #1885 :)
Note: I've split the commits into a logical progression, to make the changes easier to review.