Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git format patch: add page #2351

Merged
merged 3 commits into from
Sep 25, 2018
Merged

git format patch: add page #2351

merged 3 commits into from
Sep 25, 2018

Conversation

sbrl
Copy link
Member

@sbrl sbrl commented Sep 24, 2018

Just had to look this one up, 'cause I ended up committing to repository on a machine that I didn't have SSH keys set up on, and I'm too lazy to generate + use a authentication token :P


  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited.

  • The page follows the contributing guidelines.

@sbrl sbrl added the new command Issues requesting creation of a new page. label Sep 24, 2018
@sbrl sbrl mentioned this pull request Sep 24, 2018
5 tasks

`git format-patch {{origin}}`

- Write a patch file for all the commits between 2 revisions to stdout:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

".patch file" to be consistent with others.


- Write a .patch file for the 3 latest commits:

`git format-patch -3`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 in tokens ({{}})

@owenvoke owenvoke merged commit 28adcbc into master Sep 25, 2018
@agnivade agnivade deleted the page-git-format-patch branch September 26, 2018 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants