Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brctl: add page; id, history, kill: add examples; kill: fix a typo #2691

Merged
merged 6 commits into from
Jan 11, 2019
Merged

brctl: add page; id, history, kill: add examples; kill: fix a typo #2691

merged 6 commits into from
Jan 11, 2019

Conversation

mebeim
Copy link
Member

@mebeim mebeim commented Jan 9, 2019

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform folder (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

  • Add new page for the brctl linux command, a useful tool for creating and managing netwok ethernet interfaces.

  • Add two examples for id:

    • The most basic example: id
    • An example showing how to check the id of a different user.
  • Add one example for history on how to delete history entries.

  • Add two examples for kill on how to work with multiple processes of the same group.

  • Fixed a typo in the kill page:

    - pause a program, it until
    + pause a program until

@agnivade
Copy link
Member

agnivade commented Jan 9, 2019

Hi @mebeim - Thanks for this. But in future, kindly create separate PRs for every page. So that when we review each page, the history belongs to that single page and we can easily choose to squash/rebase the commits.

Right now, it is not possible to squash the commits from the UI because it has unrelated commits for other pages.

pages/common/kill.md Outdated Show resolved Hide resolved
pages/common/kill.md Outdated Show resolved Hide resolved
pages/common/id.md Outdated Show resolved Hide resolved
pages/linux/brctl.md Outdated Show resolved Hide resolved
@owenvoke owenvoke added page edit Changes to an existing page(s). new command Issues requesting creation of a new page. labels Jan 9, 2019
@mebeim
Copy link
Member Author

mebeim commented Jan 9, 2019

@agnivade thanks for pointing this out, I was not sure if multiple PRs would have been welcome or not. I applied the requested changes and will keep your suggestion in mind for the future.

pages/common/id.md Outdated Show resolved Hide resolved
@agnivade
Copy link
Member

agnivade commented Jan 9, 2019

Sure, no worries. But please do not force push. It makes it difficult for us to see what changed in a review.

@mebeim
Copy link
Member Author

mebeim commented Jan 9, 2019

Makes sense, thanks!

pages/common/history.md Show resolved Hide resolved
pages/common/kill.md Show resolved Hide resolved
@sbrl sbrl merged commit 3e94a31 into tldr-pages:master Jan 11, 2019
@mebeim mebeim deleted the pr-brctl branch January 11, 2019 09:36
@sbrl sbrl mentioned this pull request Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page. page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants