Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS.MD: Add @schneiderl as contributor #2899

Merged
merged 2 commits into from
Apr 12, 2019
Merged

MAINTAINERS.MD: Add @schneiderl as contributor #2899

merged 2 commits into from
Apr 12, 2019

Conversation

schneiderl
Copy link
Collaborator

@schneiderl schneiderl commented Apr 11, 2019

Just added myself as collaborator on Maintainers.md

Closes #2898

@mebeim
Copy link
Member

mebeim commented Apr 11, 2019

I'd rather say "Add @schneiderl as contributor" since it's an addition rather than an a role change. Also you lost a newline there, let's keep the formatting consistent, shall we? Oh, and by the way: welcome aboard! 😄 🎉

@mebeim mebeim added the community Issues/PRs dealing with role changes and community organization. label Apr 11, 2019
@schneiderl schneiderl changed the title MAINTAINERS.MD: Change @schneiderl status MAINTAINERS.MD: Add @schneiderl as contributor Apr 11, 2019
@schneiderl
Copy link
Collaborator Author

@mebeim made the necessary changes :)

@waldyrious
Copy link
Member

@schneiderl please keep the double lines before level-2 headings 😊

@mebeim
Copy link
Member

mebeim commented Apr 11, 2019

@waldyrious they are kept. GitHub displays the diff in a weird way, but there still are two lines before the next heading.

By the way @schneiderl with my previous comment I was talking more about the commit message than the title of the PR 😅, that's what is going to be in the history. I'm approving anyway since it can be changed when we squash-merge this so it's not really a big problem.

@mebeim mebeim merged commit 6973305 into tldr-pages:master Apr 12, 2019
@waldyrious
Copy link
Member

waldyrious commented Apr 12, 2019

@waldyrious they are kept. GitHub displays the diff in a weird way, but there still are two lines before the next heading.

Right, my bad. It's what I get for reviewing PRs late at night! 😄

Btw, thanks for the care for commit messages. It's an often overlooked detail. Keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add collaborator: @schneiderl
4 participants