Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS.md: add Rudloff and Proscream #3617

Merged
merged 3 commits into from
Nov 28, 2019
Merged

Conversation

sbrl
Copy link
Member

@sbrl sbrl commented Nov 24, 2019

Oops.... I should have done this before. Thanks to @waldyrious for reminding me!

Closes #3580
Closes #3592

@sbrl sbrl added the community Issues/PRs dealing with role changes and community organization. label Nov 24, 2019
MAINTAINERS.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@schneiderl schneiderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments left by @waldyrious it all looks good.

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after @waldyrious's comments have been addressed.

MAINTAINERS.md Outdated Show resolved Hide resolved
@sbrl
Copy link
Member Author

sbrl commented Nov 28, 2019

Fixed, @waldyrious - thanks :-)

Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@waldyrious waldyrious changed the title Update MAINTAINERS.md MAINTAINERS.md: add Rudloff and Proscream Nov 28, 2019
@waldyrious waldyrious merged commit 47a0bb6 into master Nov 28, 2019
@waldyrious waldyrious deleted the add-maintainers branch November 28, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add contributor: @Proscream add collaborator: Rudloff
6 participants