Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git notes: add page #4042

Merged
merged 2 commits into from
May 13, 2020
Merged

git notes: add page #4042

merged 2 commits into from
May 13, 2020

Conversation

sbrl
Copy link
Member

@sbrl sbrl commented May 12, 2020

In my continuing adventures to go where no tldr-pages author has gone before..... oops, I think that went a bit wrong.

@sbrl sbrl added the new command Issues requesting creation of a new page. label May 12, 2020
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/git-notes.md:3: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

Copy link
Collaborator

@ivanhercaz ivanhercaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregarding the error reported by tldr-bot, it looks good to me. I am going to perform the fix due it is something very little.

@sbrl
Copy link
Member Author

sbrl commented May 13, 2020

Haha, I always forget some syntax or other @ivanhercaz - you beat me to it :P

I was reviewing some other PRs while I waited on Travis lol

Edit: Oh yeah, this is part of #3953

Copy link
Contributor

@zlatanvasovic zlatanvasovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no clue this existed. 😆

@zlatanvasovic zlatanvasovic merged commit 4a1796c into master May 13, 2020
@zlatanvasovic zlatanvasovic deleted the page/git-notes branch May 13, 2020 08:42
@sbrl
Copy link
Member Author

sbrl commented May 14, 2020

Neither did I, but it sure looks useful lol!

sbrl added a commit that referenced this pull request May 21, 2020
Co-authored-by: Iván Hernández Cazorla <ivan@ivanhercaz.com>
Keating950 pushed a commit to Keating950/tldr that referenced this pull request May 27, 2020
Co-authored-by: Iván Hernández Cazorla <ivan@ivanhercaz.com>
Keating950 pushed a commit to Keating950/tldr that referenced this pull request May 27, 2020
Co-authored-by: Iván Hernández Cazorla <ivan@ivanhercaz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants