Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-request-pull: add page #4241

Merged
merged 3 commits into from
Aug 11, 2020
Merged

git-request-pull: add page #4241

merged 3 commits into from
Aug 11, 2020

Conversation

samuel-w
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Part of #3953

@sbrl sbrl added the new command Issues requesting creation of a new page. label Aug 2, 2020
sbrl
sbrl reviewed Aug 2, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page, @samuel-w! I've left some comments below for you to review.

pages/common/git-request-pull.md Outdated Show resolved Hide resolved
pages/common/git-request-pull.md Outdated Show resolved Hide resolved
samuel-w and others added 2 commits August 2, 2020 14:27
@samuel-w @sbrl
Update pages/common/git-request-pull.md
10fe094 
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@samuel-w @sbrl
Update pages/common/git-request-pull.md
25c8848 
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@samuel-w samuel-w requested a review from sbrl August 6, 2020 03:13
sbrl
sbrl approved these changes Aug 9, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @samuel-w ❤️

einverne
einverne approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @samuel-w for this new page. It looks good.

@owenvoke owenvoke merged commit 507c0df into tldr-pages:master Aug 11, 2020
@samuel-w samuel-w deleted the git-send-email branch November 29, 2020 00:29
@bl-ue
Copy link
Contributor

bl-ue commented Jan 6, 2021

Seems like this is what GitHub's "Pull Request" comes from :D

@bl-ue bl-ue mentioned this pull request Jan 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenvoke owenvoke owenvoke approved these changes

@einverne einverne einverne approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samuel-w @bl-ue @owenvoke @einverne @sbrl