Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-replace, w: add pages #4496

Merged
merged 16 commits into from
Oct 12, 2020
Merged

git-replace, w: add pages #4496

merged 16 commits into from
Oct 12, 2020

Conversation

unknown1924
Copy link
Contributor

w command shows who is logged in and their processes.

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

show who is logged in and their processes.
@tldr-bot
Copy link

tldr-bot commented Oct 5, 2020

The build for this PR failed with the following error(s):

Error: Parse error on line 5:
...d their processes.> More information: 
---------------------^
Expecting 'TEXT', 'DASH', 'BACKTICK', got 'GREATER_THAN'

Please fix the error(s) and push again.

fixed basic typos
@owenvoke owenvoke added the new command Issues requesting creation of a new page. label Oct 5, 2020
@owenvoke owenvoke changed the title w: add file w: add page Oct 5, 2020
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @unknown1924, thanks! I left some comments.

pages/linux/w.md Outdated Show resolved Hide resolved
pages/linux/w.md Outdated Show resolved Hide resolved
pages/linux/w.md Outdated Show resolved Hide resolved
pages/linux/w.md Outdated Show resolved Hide resolved
pages/linux/w.md Outdated Show resolved Hide resolved
pages/linux/w.md Outdated Show resolved Hide resolved
unknown1924 and others added 6 commits October 6, 2020 19:26
changed to long argument format.

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
changed to long argument format.

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Improved readability.

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@unknown1924
Copy link
Contributor Author

unknown1924 commented Oct 6, 2020

Hey @unknown1924, thanks! I left some comments.

Thanks for the suggestions! I've made the changed as per the suggestions.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page, @unknown1924! I've left some comments below for you to review.

pages/linux/w.md Outdated Show resolved Hide resolved
pages/linux/w.md Outdated Show resolved Hide resolved
pages/linux/w.md Outdated Show resolved Hide resolved
pages/linux/w.md Outdated Show resolved Hide resolved
unknown1924 and others added 5 commits October 7, 2020 12:25
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
added suggestions

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
added page for git-replace command.
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move git-replace.md to another PR. This was only for w.

pages/common/git-replace.md Outdated Show resolved Hide resolved
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, @unknown1924! Looks like something's gone skew here, as I'm now seeing an extra page here for git replace. Thanks so much for the contribution! Next time though, it would be great if you could open a separate pull request for that, as it's going to draw out the review process here and prevent the w page you've written from being merged until we've reviewed and accepted git replace too.

Anyway, I've left some comments below for you to review about git replace 🙂

pages/common/git-replace.md Outdated Show resolved Hide resolved
pages/common/git-replace.md Outdated Show resolved Hide resolved
@sbrl sbrl changed the title w: add page w, git replace: add pages Oct 7, 2020
unknown1924 and others added 3 commits October 10, 2020 01:41
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@navarroaxel navarroaxel changed the title w, git replace: add pages git-replace, w: add pages Oct 9, 2020
@navarroaxel navarroaxel requested a review from sbrl October 9, 2020 20:14
@unknown1924
Copy link
Contributor Author

unknown1924 commented Oct 9, 2020

Please move git-replace.md to another PR. This was only for w.

I'm not sure how this PR for git-replace came here.
I saw request for git-replace so made a PR on that.
This PR was only intended for w.md
Do you think it would be possible to merge both w.md and git-replace.md in a single PR?

@navarroaxel
Copy link
Member

@unknown1924 Looks like you push that commit to this branch lol things happens 🤷‍♂️

git is a really important command, so we want to track his changes carefully. Please send a commit deleting the git-replace.md file in this PR and create a new one with the git-replace.md file.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @unknown1924 😺

@sbrl sbrl merged commit b3c2c81 into tldr-pages:master Oct 12, 2020
@unknown1924
Copy link
Contributor Author

Thanks, @unknown1924 😺

I'm so sorry I didn't address the issue earlier, had some exams so a bit busy.
I'll look out for common silly mistakes while sending PR next time!
Thanks for helping out, I did learn quite a lot from this :)

@sbrl
Copy link
Member

sbrl commented Oct 14, 2020

No worries, @unknown1924! Glad it's been a learning experience - we hope you'll come back with another PR soon :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants